Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't ignore 400 status code errors #66

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

don't ignore 400 status code errors #66

wants to merge 1 commit into from

Conversation

pymonger
Copy link
Contributor

  • need to expose errors in ES template format otherwise they go undetected and the ES template is not applied
  • bump version

@pymonger
don't ignore 400 status code errors
0e054cf 
- need to expose errors in ES template format otherwise they go undetected
  and the ES template is not applied
- bump version
@pymonger
Copy link
Contributor Author

@DustinKLo: as I was updating the nisar-pcm ES template for GRQ to disable indexing of additional fields, I had an error in my format which went undetected. I think all I needed was to remove the ignore=400 from the install_es_template.py script but I also removed it from its occurrence in other scripts. Should i just revert those others back to ignore=400?

@DustinKLo
Copy link
Contributor

DustinKLo commented Oct 24, 2023 •
edited
Loading

i think i added the ignore=400 is when we run sds update grq it will return a 400 b/c the indices already exist

i guess a better way to do it is to check if the indices exists first before running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayanan mcayanan Awaiting requested review from mcayanan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pymonger @DustinKLo